Add field arithmetic skeleton #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This defines (but does not implement): * conversion to and from the curve25519-dalek packed `Scalar` type; * addition; * subtraction; * multiplication; * zero & one constructors and Default; * inversion; The implementation in curve25519-dalek allows doing operations either in Montgomery form or not in Montgomery form; I think that for this use-case, it would be better to require that a `FieldElement` is *always* in Montgomery form, so that the multiplication is always Montgomery multiplication. We can also probably save some time by allowing the representatives to lie in the range [0, 2*l) instead of [0, l) as in the original implementation (cf. "Montgomery Multiplication Needs No Final Subtractions").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't yet fill in the implementations, so it won't run, but it means that it's possible to start using the api with
cargo check. Progress on #1 to unblock other issues.